Review: Approve code + if store == None:
That should probably be 'is' 18:21:05 < wgrant> stub: What's self.fixture for in the tests? 18:21:13 < wgrant> stub: I don't see what it does that self.useFixture() doesn't 18:22:18 < stub> Just me cargo culting. I can fix that. 18:22:37 < wgrant> That should mean you can delete tearDown 18:22:55 < wgrant> I'd also appreciate a comment that conn_str_pgbouncer works because PGBouncerFixture sets PGPORT 18:23:03 < wgrant> It's not at all obvious unless you know that code well 18:24:38 < wgrant> Otherwise that looks great -- https://code.launchpad.net/~stub/launchpad/replication/+merge/121410 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
