You raise an excellent point. The branch setTarget() method currently only raises a BranchTargetError if a non-private team tries to retarget a branch to create a private junk branch. So it does seem like the setTarget() method needs to be extended to respect the sharing policy rules that exist on any target product. That this code does not exist yet is perhaps an oversight. So in that sense yes this could really be called feature work.
On Fri 14 Sep 2012 23:03:43 EST, Curtis Hovey wrote: > Review: Needs Information code > > Hi Ian. > > I love this branch. I am very impressed with your widget. I have a sharing > question that might mean this branch is feature work, not maintenance work. > Happens if I try to retarget a Public branch with a Proprietary only branch > sharing policy? I think an exception should be raised. Maybe we need a second > branch to add a vocabulary of projects that permit the branches information > type? > > I think we can land your branch, but we may want to delay it until we know > how to avoid an exception raised by shairng violations. -- https://code.launchpad.net/~wallyworld/launchpad/branch-move_project-402915/+merge/124333 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
