Review: Approve code
11 + description=_('Obsolete field for security contact')),
This is used in the webservice docs. Perhaps something like "Security contact
(obsolete; always None)"?
24 @property
25 + def security_contact(self):
26 + return None
Isn't this just 'security_contact = None'?
51 + self.assertEqual(None, api_prod['security_contact'])
assertIs should be used with None, not assertEqual.
54 + self.assertFalse(api_prod.has_key('security_contact'))
has_key is pretty rare; we usually prefer to use "'key' in dict" instead. If
you use that you can probably assertNotIn.
--
https://code.launchpad.net/~stevenk/launchpad/export-security_contact-for-1.0/+merge/125092
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
