Oh, another thing I noticed but forgot to include the the first comment: The comment on lines 1955-1956 of the diff (in test_new_packageset_uploader_repeated) contain an error:
# Creating the same permission repeatedly should return the re-use the # existing permission. I believe this should read # Creating the same permission repeatedly should re-use the existing # permission. -- https://code.launchpad.net/~stefanor/launchpad/edit-packagesets/+merge/124555 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~stefanor/launchpad/edit-packagesets into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp

