Review: Needs Fixing I Raphael,
The branch looks good. Before merging, I have a couple doubts: 1. So since celeryconfig.py is being installed with maas-region-controller I'm guessing that this will be run by the upstart job in lp:~rvb/maas/recreate-region-worker right? 2. celeryconfig_cluster.py is now being run by the upstart job for maas-cluster-controller. 3. celeryconfig_common.py is sourced by both. So if I understood correctly, what happens when the region-controller and cluster-controller are installed on the same machine? won't having 2 celery upstart jobs collide with each other some how? Now, given that there's gonna be 2 maas-celery.upstart jobs, then these need to have different names. e.g maas-region-celery.upstart and maas-cluster-celery.upstart otherwise region-controller and cluster-controller wont be able to be installed at the same time due to both having the same file. Once this change is made, please update debian/rules to install such files. -- https://code.launchpad.net/~rvb/maas/add-maas-cluster-packaging/+merge/127002 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~rvb/maas/add-maas-cluster-packaging into lp:~maas-maintainers/maas/packaging. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
