> If you are rewrapping this because you removed 'text()' you can get > rid of the parenthesis as well.
Will do. > Because we aren't deleting the data from NodeCommissioningResult > (yet), the proper reverse migration is to just drop the column from > Node and you are done (no need to repopulate the other table, I think). Right, we're not deleting data, but on a freshly commissioned node we're only adding it in one place at the moment. In the review of that merge proposal storing the data twice was mentioned as an option, but for now the downgrade ensures a subsequent upgrade will retain all the data. > Otherwise, it is nice that this works, but isn't the real test if it > works during a 'apt-get upgrade' ? Do you expect that to work? I am confident this component will work, but have little clue as to the rest of MaaS. Hope so! :) -- https://code.launchpad.net/~gz/maas/populate_hardware_details/+merge/127551 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~gz/maas/populate_hardware_details into lp:maas. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
