Review: Approve This looks reasonable.
Setting information_type to PUBLIC is a bit of a DRY violation, since createProject takes care of that when unspecified or None. It's not the only DRY violation in this regard, as the EnumCol declares a default (but I can't figure out how to access it). Similarly, declaring private_projects_flag is a DRY violation. I would prefer if you moved it to a module-level variable, since it's already used in two other places. -- https://code.launchpad.net/~deryck/launchpad/actually-save-info-type-on-project-create/+merge/127863 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
