>Other thing is less severe, but more stlylish. >put the actual stuff you're doing in the 'main' routine. > >rather than outside (aptget, loadmodules)...
Andres is doing it correctly IMO. Refactoring into small, well-defined functions makes debugging easier, testing easier and writing easier. Alas, there are no tests. How can I convince you guys to write tests? -- https://code.launchpad.net/~andreserl/maas/maas_ipmi_autodetection/+merge/127911 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~andreserl/maas/maas_ipmi_autodetection into lp:maas. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
