Review: Disapprove I am rejecting this branch because a lot more work is needed to address this bug. As can be seeing lib/lp/app/browser/tales.py, getting the URL for a logo or mugshot is not simple. The proposed interface changes are fine. The implementation would need to move the URL logic from tales.py into the model. And any changes will need to be tested. -- https://code.launchpad.net/~nigelbabu/launchpad/logo-links-713873/+merge/88631 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
