> Looks good. A couple of minor points: > > It would be nice to fix the long line on line 26 of the diff.
Doh, thanks for the heads up on that. > Would it be possible to put the explicit style attributes on line 31 and 79 > into a stylesheet? If there was a true widget with CSS properties I'd definitely move it off. As it is, the best shortcut might be to try to turn the div's into p's of textual content, however they're set to have 0 padding and margin (ugh!). So for now I'm going to leave this as existing bad code and hope someone gets a change to come behind and do a nice portlet widget with CSS that can be reused rather than stick such a specific rule on #information-type-description which seems just as bad. -- https://code.launchpad.net/~rharding/launchpad/info_portlet_1052551/+merge/129706 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
