Review: Approve code
Remove the submit-twice-error you added to
lib/lp/registry/doc/commercialsubscription.txt because you wrote a unit test
for it.
I see the template is doing python evaluation twice to chose true ans false
outcomes
condition="python: vouchers or view_errors"
This check (or both) can be moved into the view so that python: is not used in
TAL where is it doing late compilation.
--
https://code.launchpad.net/~wallyworld/launchpad/vouchers-timeout-1014641/+merge/129862
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
