Review: Approve code Hi Rick,
Some comments on your branch: * In genAffiliatedProductSql there is a lot of repetition in the queries that could be factored out so you DRY as the first query you return is a the same as the final one minus one clause. Give a shot at refactoring if you don't mind. * Thanks for the nice error messages when the account cannot be deactivated. * The tests are clear and easy to follow. Thanks. -- https://code.launchpad.net/~rharding/launchpad/related_projects_1063272/+merge/130414 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
