> > #318 I would add the new argument to the end of the arg list. While > *probably* all of the args are being invoked as keyword args, > they *can* be invoked as positional, and your change throws off the ordering > in that case. I won't block approval on that, but please > fix it before landing.
As discussed on our stand up, I've checked all the usages of the createTask method and the new parameter will work fine as implemented. I'd prefer to keep it near the start of the argument list so that we can more sensibly add additional task attributes (if required) to the end of the parameter list. -- https://code.launchpad.net/~wallyworld/launchpad/bug-distrotask-timeout-1012309/+merge/131308 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
