Review: Approve Looks good, generally. As mentioned here in person, we need an XXX to note that we don't want this check for NULL once Product.information_type cannot be NULL. Once the XXX is in place, landing this sounds fine. Also, please add a card to the Kanban board reminding us to revisit this code. -- https://code.launchpad.net/~adeuring/launchpad/filter-private-product-RosettaApplication/+merge/131613 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
