Review: Approve This branch looks good Abel, some minors follow.
28 +class IProductLimitedView(Interface): 29 + """Attributes that must be visible for person with artifact grants 30 + on bugs, branches or specifications for the product, 31 + """ The docstring ends with a comma. 203 + def test_access_LimitedView_proprietary_product(self): Feel free to ignore this suggestion if you want: maybe this test could be splitted in two parts: test unauthorized users and then test users with access grant on something. -- https://code.launchpad.net/~adeuring/launchpad/product-lp-limitedview/+merge/133046 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
