Review: Approve

Abel--

This looks ok, just one nitpick you can address before landing.

#16: It seems odd to have a test with no assertions--I believe this may throw
off some test machinery. At a minimum, probably worth testing that the bug
does show in contents:

    contents = view.render()
    self.assertTrue(bug.title in contents)

-- 
https://code.launchpad.net/~adeuring/launchpad/product-lp-limitedview-2/+merge/133481
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to