Review: Approve Rick--
Looks good. I cannot tell you how happy I am to see that _shim/_unshim mess in the info_type js tests go away. Two points, neither are blockers to approval but should be dealt with before landing: #1381: Pretty sure I see a copy paste error here--"The information on this page is private" dropped into the middle of the comment. #1691: Is there a bug for this? Should one be filed and added to this XXX? And don't forget to add your name to the XXX comment so being following up know who to talk to. -- https://code.launchpad.net/~rharding/launchpad/wire_new_banner/+merge/133927 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
