The proposal to merge lp:~sinzui/launchpad/unicode-project-group-bug into lp:launchpad has been updated.
Description changed to: The report a bug from a project group form fails if the summary contains unicode. form forwards the request to the selected project, but the summary is assumed to be ascii. The call to URLEncode fails when give unicode. -------------------------------------------------------------------- RULES Pre-implementation: no one * ProjectGroupFileBugGuidedView.projectgroup_search_action needs to decode the summary before passing it to URLEncode. ADDENDUM: * The redirect does not go to the bug domain. It should. QA * Visit https://bugs.qastaging.launchpad.net/ubuntu-fr-website-project/+filebug * Choose Forum Ubuntu-fr * Enter "Le bouton liste à puces n'est pas correct" in the summary field. * Choose Continue * Verify the page redirect to the Forum Ubuntu-fr project and shows the matches and/or bug form. * Verify the url using the bugs host. LINT lib/lp/bugs/browser/bugtarget.py lib/lp/bugs/browser/tests/test_bugtarget_filebug.py LoC I have a 3000 line credit this week. TEST ./bin/test -vvc -t ProjectGroup lp.bugs.browser.tests.test_bugtarget_filebug IMPLEMENTATION I discovered that the redirect url went to the wrong host when I was investigating a fix. I added the missing rootsite arg and test for it. I expected the test to verify that the summary is encoded as utf8 before passing it to URLEncode(). Note that will bug tags have to be unicode in tests, the validator requires that they are ascii; it is not possibly to have a similar problem with bug tags. lib/lp/bugs/browser/bugtarget.py lib/lp/bugs/browser/tests/test_bugtarget_filebug.py For more details, see: https://code.launchpad.net/~sinzui/launchpad/unicode-project-group-bug/+merge/134154 -- https://code.launchpad.net/~sinzui/launchpad/unicode-project-group-bug/+merge/134154 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~sinzui/launchpad/unicode-project-group-bug into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
