Jeroen T. Vermeulen has proposed merging lp:~jtv/juju-core/mpv-interface-update
into lp:~maas-maintainers/juju-core/maas-provider-skeleton.
Commit message:
Conform (well, promise to conform) to recent update of the EnvironProvider
interface.
Requested reviews:
MAAS Maintainers (maas-maintainers)
For more details, see:
https://code.launchpad.net/~jtv/juju-core/mpv-interface-update/+merge/152117
We're having some problems compiling today. Some of the errors seem to be
caused by version skew with dependencies, but others are because the
EnvironProvider interface grew a new method, making our implementation of that
interface suddenly not an implementation of that interface.
Also, we just took up the habit of documenting interface-mandated methods by
referring to the interface. I'm adding a few of those comments here.
I haven't been able to compile this branch yet (since I can't compile any
juju-core code right now) but given that nothing compiles at the moment, we
might as well get this small part of the fix moving.
Jeroen
--
https://code.launchpad.net/~jtv/juju-core/mpv-interface-update/+merge/152117
Your team MAAS Maintainers is requested to review the proposed merge of
lp:~jtv/juju-core/mpv-interface-update into
lp:~maas-maintainers/juju-core/maas-provider-skeleton.
=== modified file 'environs/maas/environprovider.go'
--- environs/maas/environprovider.go 2013-02-05 06:30:22 +0000
+++ environs/maas/environprovider.go 2013-03-07 08:39:23 +0000
@@ -21,14 +21,22 @@
return NewEnviron(cfg)
}
+// BoilerplateConfig is specified in the EnvironProvider interface.
+func (*maasEnvironProvider) BoilerplateConfig() string {
+ panic("Not implemented.")
+}
+
+// SecretAttrs is specified in the EnvironProvider interface.
func (*maasEnvironProvider) SecretAttrs(*config.Config) (map[string]interface{}, error) {
panic("Not implemented.")
}
+// PublicAddress is specified in the EnvironProvider interface.
func (*maasEnvironProvider) PublicAddress() (string, error) {
panic("Not implemented.")
}
+// PrivateAddress is specified in the EnvironProvider interface.
func (*maasEnvironProvider) PrivateAddress() (string, error) {
panic("Not implemented.")
}
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
