Review: Approve code 656 + bq = build.queueBuild() 657 + bq.markAsBuilding(builder) 658 + interactor = BuilderInteractor(builder, slave) 659 + d = interactor._startBuild(bq, BufferLogger())
This block is repeated twice in the same test, I'd prefer to see it refactored into a method like the one you replaced. Other than that, this branch looks great. -- https://code.launchpad.net/~wgrant/launchpad/builderinteractor-c-b-b/+merge/182290 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
