Review: Approve code

32      +def debug(logger, msg):
33      + if logger is not None:
34      + logger.debug(msg)

This is only called once, so I'd probably inline it.

Otherwise I think this is fine. But we might need to think a bit about how 
pocket copies behave: eg. a copy from -proposed to -updates will reimport the 
translations. This is probably OK, but something to think about.
-- 
https://code.launchpad.net/~ursinha/launchpad/bug-1201485/+merge/186305
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to