Review: Needs Information Overriding the config should usually only been done in high-level integration tests. What was the rationale behind having makeSeedStructures() look up the config option, rather than doing it in generateExtraOverrides() or even process()? That would surely make testing less ugly. -- https://code.launchpad.net/~cjwatson/launchpad/configurable-germinate-base/+merge/194340 Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
