Review: Approve code
127 + def build(self):
128 + if self.options.locale is not None:
The locale and non-locale cases seem to be almost entirely divergent. Do we
really need both?
365 + def gatherResults(self):
366 + """Gather the results of the build and add them to the file cache."""
367 + for entry in sorted(os.listdir(self.build_path)):
368 + if entry.startswith("livecd."):
369 + self._slave.addWaitingFile(
370 + os.path.join(self.build_path, entry))
There's no manifest-like file from which we can parse the build result
filenames?
--
https://code.launchpad.net/~cjwatson/launchpad-buildd/livefs/+merge/193682
Your team Launchpad code reviewers is subscribed to branch lp:launchpad-buildd.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
