Review: Approve Nice!
I presume you will coordinate with webops to get those changes propagated to production configs at some point after it gets released. I am assuming (by the code) it won't break existing code with old-style configs because you have modified getRootURL() do operate properly for 'special' hosts independently of the config.rooturl. Nonetheless, it will be great to have 'sane' configuration for those hosts in production. -- https://code.launchpad.net/~wgrant/launchpad/no-custom-xmlrpc-rooturl/+merge/201891 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
