This is now broken in the opposite direction. If there is no gap between two files, the comments end up a line too early.
On 16/07/14 03:35, Chris Johnston wrote: >> Also, it probably makes sense to have a gap between hunks, at least when one >> is skipped. In expected-6, the hunk at 70 seems to lead directly into 88, but >> in the original there's one at 80. > > How do you suggest doing the gap? A blank line or a line that starts with > '>', or maybe even some sort of text to indicate that a hunk is skipped? > Also, how do you want to handle if multiple hunks in a row (or even a whole > file) are mising? One line for each hunk missing, one line total, if a file > is missing and it's the first file should we start out with a blank line? I > almost think that we should see what type of feedback we get the way things > are and then iterate again. I think just a blank line makes sense. A line starting with ">" would indicate that it was quoting the diff, which is false. -- https://code.launchpad.net/~cjohnston/launchpad/short-ic-emails/+merge/225095 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
