The proposal to merge lp:~cjwatson/launchpad/git-defaults into lp:launchpad has 
been updated.

Description changed to:

Implement target and owner-target default Git repositories.

This presents two different layers because of the different ways we'll need to 
call this.  For the webservice, it's simplest to just have 
{get,set}DefaultRepository* methods on GitRepositorySet.  But for some internal 
purposes, it's useful to have an ICanHasDefaultGitRepository abstraction that's 
sortable and so on, much like ICanHasLinkedBranch: this is useful when working 
out Git identities and when setting defaults from the XML-RPC endpoint.

I chose to have {get,set}DefaultRepository and 
{get,set}DefaultRepositoryForOwner be separate methods rather than taking an 
optional owner keyword argument, because I felt that the optional argument 
causing completely different semantics was a little too easy to get wrong for 
webservice users.  It's marginally more awkward internally but not too bad.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/git-defaults/+merge/250474
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to