Review: Approve
Diff comments:
>
> === modified file 'lib/lp/services/job/tests/test_celery_configuration.py'
> --- lib/lp/services/job/tests/test_celery_configuration.py 2013-05-15
> 04:41:33 +0000
> +++ lib/lp/services/job/tests/test_celery_configuration.py 2015-08-03
> 08:18:40 +0000
> @@ -33,13 +34,10 @@
> for name in queue_names:
> self.assertEqual(name, queues[name]['binding_key'])
>
> - self.assertEqual('localhost', config['BROKER_HOST'])
> - # BROKER_PORT changes between test runs, so just check that it
> - # is defined.
> - self.assertTrue('BROKER_PORT' in config)
> - self.assertEqual('guest', config['BROKER_USER'])
> - self.assertEqual('guest', config['BROKER_PASSWORD'])
> - self.assertEqual('/', config['BROKER_VHOST'])
> + # The port changes between test runs.
> + self.assertThat(
> + config['BROKER_URL'],
> + MatchesRegex('^amqp://guest:guest@localhost:\\d+//'))
r'...\d+...' would be slightly nicer.
> self.assertFalse(config['CELERY_CREATE_MISSING_QUEUES'])
> self.assertEqual('job', config['CELERY_DEFAULT_EXCHANGE'])
> self.assertEqual('launchpad_job', config['CELERY_DEFAULT_QUEUE'])
--
https://code.launchpad.net/~wgrant/launchpad/celery-3.1/+merge/266687
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
