Review: Approve
Diff comments:
>
> === modified file 'lib/lp/testing/fixture.py'
> --- lib/lp/testing/fixture.py 2015-06-12 17:50:34 +0000
> +++ lib/lp/testing/fixture.py 2015-10-02 00:19:49 +0000
> @@ -113,6 +113,7 @@
> # via pgbouncer. Otherwise, we would need to temporarily
> # overwrite the database connection strings in the config.
> self.useFixture(EnvironmentVariableFixture('PGPORT', str(self.port)))
> + self.useFixture(EnvironmentVariableFixture('PGHOST', 'localhost'))
This could use a comment.
>
> # Reset database connections so they go through pgbouncer.
> self._maybe_reconnect_stores()
--
https://code.launchpad.net/~wgrant/launchpad/af-unix-testsuite/+merge/273159
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
