Review: Approve code "archive=None" as an argument doesn't scream "use branches instead" to me, but this code is rarely touched so it'll do.
Diff comments: > === modified file 'cronscripts/update-pkgcache.py' > --- cronscripts/update-pkgcache.py 2013-01-07 02:40:55 +0000 > +++ cronscripts/update-pkgcache.py 2016-05-26 16:31:14 +0000 > @@ -40,7 +40,8 @@ > """Update package caches for the given location. > > 'archive' can be one of the main archives (PRIMARY, PARTNER or > - EMBARGOED) or even a PPA. > + EMBARGOED), a PPA, or None to update caches of official branch > + links. While you're here you might as well drop EMBARGOED. > > This method commits the transaction frequently since it deal with > a huge amount of data. -- https://code.launchpad.net/~cjwatson/launchpad/sspb-cache/+merge/295852 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
