Review: Approve LGTM - This is another branch where we're inheriting test cases, which makes me sad...
Diff comments: > > === modified file 'lib/lp/bugs/tests/test_bugwatch.py' > --- lib/lp/bugs/tests/test_bugwatch.py 2015-10-15 14:09:50 +0000 > +++ lib/lp/bugs/tests/test_bugwatch.py 2016-07-04 17:24:09 +0000 > @@ -375,6 +375,17 @@ > bug_id = '12345' > > > +class GitHubBugTrackerExtractBugTrackerAndBugTest( > + ExtractBugTrackerAndBugTestBase, unittest.TestCase): Another great place where testscenarios would make this much nicer. Tests that inherit other test case classes make me really sad. > + """Ensure BugWatchSet.extractBugTrackerAndBug works for GitHub Issues > URLs. > + """ > + > + bugtracker_type = BugTrackerType.GITHUB > + bug_url = 'https://github.com/user/repository/issues/12345' > + base_url = 'https://github.com/user/repository/issues' > + bug_id = '12345' > + > + > class TestBugWatch(TestCaseWithFactory): > > layer = LaunchpadZopelessLayer -- https://code.launchpad.net/~cjwatson/launchpad/github-link/+merge/299074 Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/github-link into lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
