Diff comments:
> > === modified file 'lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py' > --- lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py 2014-10-29 > 06:04:09 +0000 > +++ lib/lp/archivepublisher/scripts/generate_ppa_htaccess.py 2016-07-13 > 20:42:37 +0000 > @@ -274,6 +275,22 @@ > *extra_expr) > return new_ppa_tokens > > + def getDeactivatedNamedTokens(self, since=None): > + """Return result set of named tokens deactivated since given time.""" > + now = datetime.now(pytz.UTC) > + > + store = IStore(ArchiveAuthToken) > + extra_expr = [] > + if since: > + extra_expr = [ArchiveAuthToken.date_deactivated >= since] > + tokens = store.find( > + ArchiveAuthToken, > + ArchiveAuthToken.name != None, > + ArchiveAuthToken.date_deactivated != None, > + ArchiveAuthToken.date_deactivated <= now, The "date_deactivated != None" shows the intention of the query more explicitly imho. As to the "<= now" condition, the idea is to allow setting expiration dates in the future (eg. see `token4` in `test_getDeactivatedNamedTokens_only_those_since_last_run`). > + *extra_expr) > + return tokens > + > def getNewPrivatePPAs(self, since=None): > """Return the recently created private PPAs.""" > store = IStore(Archive) -- https://code.launchpad.net/~maxiberta/launchpad/named-auth-tokens-htaccess/+merge/300002 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
