Review: Approve


Diff comments:

> 
> === modified file 'lib/lp/archivepublisher/scripts/processdeathrow.py'
> --- lib/lp/archivepublisher/scripts/processdeathrow.py        2014-08-09 
> 19:45:00 +0000
> +++ lib/lp/archivepublisher/scripts/processdeathrow.py        2016-09-19 
> 10:57:46 +0000
> @@ -71,3 +79,4 @@
>              else:
>                  self.logger.debug("Committing")
>                  self.txn.commit()
> +            clear_request_started()

This should be in a finally block instead, so that it's called even if 
death_row.reap raises an exception.



-- 
https://code.launchpad.net/~wgrant/launchpad/smaller-publisher-oopses/+merge/306074
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to