Review: Approve
Diff comments: > > === modified file 'lib/lp/scripts/runlaunchpad.py' > --- lib/lp/scripts/runlaunchpad.py 2017-12-19 17:16:38 +0000 > +++ lib/lp/scripts/runlaunchpad.py 2018-03-16 14:33:02 +0000 > @@ -19,7 +19,7 @@ > > from lp.services.config import config > from lp.services.daemons import tachandler > -from lp.services.googlesearch import googletestservice > +from lp.services.sitesearch import googletestservice Please re-sort this, and all the other similar Python imports. utilities/format-new-and-modified-imports will help with this, although do check over its output as it has a few bugs in corner cases. > from lp.services.mailman import runmailman > from lp.services.osutils import ensure_directory_exists > from lp.services.pidfile import ( > > === modified file 'lib/lp/services/configure.zcml' > --- lib/lp/services/configure.zcml 2015-09-18 01:32:20 +0000 > +++ lib/lp/services/configure.zcml 2018-03-16 14:33:02 +0000 > @@ -11,7 +11,7 @@ > <include package=".feeds" /> > <include package=".fields" /> > <include package=".geoip" /> > - <include package=".googlesearch" /> > + <include package=".sitesearch" /> Please re-sort this. > <include package=".gpg" /> > <include package=".identity" /> > <include package=".inlinehelp" file="meta.zcml" /> -- https://code.launchpad.net/~maxiberta/launchpad/rename-googlesearch-as-sitesearch/+merge/341521 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
