Review: Approve code
Diff comments: > > === modified file 'lib/lp/soyuz/model/archivesubscriber.py' > --- lib/lp/soyuz/model/archivesubscriber.py 2015-09-23 15:38:13 +0000 > +++ lib/lp/soyuz/model/archivesubscriber.py 2019-03-08 17:05:57 +0000 > @@ -94,9 +97,7 @@ > > def cancel(self, cancelled_by): > """See `IArchiveSubscriber`.""" > - self.date_cancelled = UTC_NOW > - self.cancelled_by = cancelled_by > - self.status = ArchiveSubscriberStatus.CANCELLED > + ArchiveSubscriberSet().cancel([self.id], cancelled_by) getUtility? > > def getNonActiveSubscribers(self): > """See `IArchiveSubscriber`.""" -- https://code.launchpad.net/~cjwatson/launchpad/archive-subscriber-refactor-cancel/+merge/364169 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
