Review: Approve
Diff comments:
>
> === modified file 'lib/lp/code/interfaces/branch.py'
> --- lib/lp/code/interfaces/branch.py 2019-04-01 10:09:31 +0000
> +++ lib/lp/code/interfaces/branch.py 2019-04-17 10:35:37 +0000
> @@ -1120,6 +1120,11 @@
> def unscan(rescan=True):
> """Reset this branch's scan data and optionally request a scan."""
>
> + @export_write_operation()
> + @operation_for_version('devel')
> + def rescan():
> + """Wrapper around rescan for compatibility with IGitRepositoryEdit"""
Can you give this a slightly more webservice-documentation-friendly
description? (Also remember that the first sentence of our docstrings should
typically end with a full stop.)
Alternatively, we could just not export this method; but it does seem friendly
to export it.
> +
>
> class IBranchEditableAttributes(Interface):
> """IBranch attributes that can be edited.
--
https://code.launchpad.net/~twom/launchpad/add-rescan-link-to-merge-proposals/+merge/366060
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
