Review: Approve code
Diff comments: > > === modified file 'lib/lp/soyuz/interfaces/distroarchseries.py' > --- lib/lp/soyuz/interfaces/distroarchseries.py 2019-07-30 11:38:18 > +0000 > +++ lib/lp/soyuz/interfaces/distroarchseries.py 2019-09-04 14:01:22 > +0000 > @@ -216,6 +230,21 @@ > this distro arch series. > """ > > + def getFilter(): > + """Get the filter for packages to build for this architecture, if > any. > + > + Packages are normally built for all available architectures, subject > + to any constraints in their `Architecture` field. If a filter is > + set, then it applies the additional constraint that packages not > + included by the filter will not be built for this architecture. > + """ getSourceFilter, maybe? > + > + def isSourceIncluded(sourcepackagerelease): > + """Is this source package included in this distro arch series? > + > + :param sourcepackagerelease: An `ISourcePackageRelease` to check. > + """ I'm not 100% convinced that this should take an SPR rather than an SPN, but it probably doesn't matter too much. > + > > class IDistroArchSeriesModerate(Interface): > -- https://code.launchpad.net/~cjwatson/launchpad/das-filter-model/+merge/372261 Your team Launchpad code reviewers is subscribed to branch lp:launchpad. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
