Colin Watson has proposed merging ~cjwatson/lp-signing:fix-subprocess-logging
into lp-signing:master.
Commit message:
Bump subprocess log output to info
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/lp-signing/+git/lp-signing/+merge/387119
It doesn't totally make sense at debug, and certainly not in the case where it
corresponds to a non-zero exit status.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/lp-signing:fix-subprocess-logging into lp-signing:master.
diff --git a/charm/lp-signing/layer.yaml b/charm/lp-signing/layer.yaml
index 76ba930..fcded8f 100644
--- a/charm/lp-signing/layer.yaml
+++ b/charm/lp-signing/layer.yaml
@@ -17,7 +17,6 @@ options:
port: 8000
ols-wsgi:
app: lp_signing.webapp:app
- log_level: debug
ols-pg:
databases:
db:
diff --git a/lp_signing/model/key.py b/lp_signing/model/key.py
index a1363ea..a98d7c5 100644
--- a/lp_signing/model/key.py
+++ b/lp_signing/model/key.py
@@ -100,7 +100,7 @@ def _log_subprocess_run(args, **kwargs):
for line in process.stdout.splitlines():
if isinstance(line, bytes):
line = line.decode("UTF-8", errors="replace")
- _log.debug("%s: %s", args[0], line)
+ _log.info("%s: %s", args[0], line)
# Dealing with subprocess.run(check=True) here, so we have the
# opportunity to see the command output in a debug log above.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp