Tom Wardill has proposed merging ~twom/launchpad:stats-request-timings into
launchpad:master.
Commit message:
Add traversal duration timings
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~twom/launchpad/+git/launchpad/+merge/390256
Use the existing duration timing mechanisms, but output to statsd as well.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~twom/launchpad:stats-request-timings into launchpad:master.
diff --git a/lib/lp/services/webapp/publication.py b/lib/lp/services/webapp/publication.py
index a289f44..8b5a41d 100644
--- a/lib/lp/services/webapp/publication.py
+++ b/lib/lp/services/webapp/publication.py
@@ -568,6 +568,9 @@ class LaunchpadBrowserPublication(
traversal_duration = time.time() - request._traversal_start
request.setInWSGIEnvironment(
'launchpad.traversalduration', traversal_duration)
+ # Update statsd, timing is in milliseconds
+ getUtility(IStatsdClient).timing(
+ 'traversal_duration,success=True', traversal_duration * 1000)
if request._traversal_thread_start is not None:
traversal_thread_duration = (
_get_thread_time() - request._traversal_thread_start)
@@ -612,6 +615,9 @@ class LaunchpadBrowserPublication(
traversal_duration = now - request._traversal_start
request.setInWSGIEnvironment(
'launchpad.traversalduration', traversal_duration)
+ # Update statsd, timing is in milliseconds
+ getUtility(IStatsdClient).timing(
+ 'traversal_duration,success=False', traversal_duration * 1000)
if thread_now is not None:
traversal_thread_duration = (
thread_now - request._traversal_thread_start)
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
