Colin Watson has proposed merging
~cjwatson/launchpad:testfix-py3-sane-environment into launchpad:master.
Commit message:
Don't copy environ in BasicLaunchpadRequest.__init__
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/392329
This broke pagetest access logging, which relies on reading the userid and
pageid back from the environment.
Fixes lib/lp/app/stories/basics/xx-pagetest-logging.txt test failure caused by
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/392140.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:testfix-py3-sane-environment into launchpad:master.
diff --git a/lib/lp/services/webapp/servers.py b/lib/lp/services/webapp/servers.py
index 5c82ad0..bcf1621 100644
--- a/lib/lp/services/webapp/servers.py
+++ b/lib/lp/services/webapp/servers.py
@@ -584,7 +584,6 @@ class BasicLaunchpadRequest(LaunchpadBrowserRequestMixin):
# chance to recode anything. This change will convert a 400
# error to a 404, because traversal will raise NotFound when it
# encounters a non-ASCII path part.
- environ = dict(environ)
pi = environ['PATH_INFO']
if isinstance(pi, bytes):
pi = pi.decode('utf-8', 'replace')
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
