Thanks Thiago! Addressed all comments in the code apart from below 2:
1: The self.hosting_fixture is needed because when we render the MP we fetch commits since the start of review. 2: I did have the checkout command in there for the GitRefPage initial MP but when we discussed with Colin we agreed that it's better to take it out because we don't know the ancestor branch at that point. MP now ready for another look. -- https://code.launchpad.net/~ilasc/launchpad/+git/launchpad/+merge/393312 Your team Launchpad code reviewers is requested to review the proposed merge of ~ilasc/launchpad:git-merge-instructions-mp into launchpad:master. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
