Review: Approve

This is pretty difficult to follow, but I'm OK with it if it works.

However, did you consider instead using storm.twisted.transact for this?  It's 
designed for this sort of thing, and it might be possible to use it to make 
things significantly easier to follow.
-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/394494
Your team Launchpad code reviewers is subscribed to branch 
~pappacena/launchpad:mirror-prober-untwist-db-calls.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to