Review: Approve db I'm OK with this, but I wonder if it's worth folding the necessary AccessArtifact-related changes into this patch as well? See database/schema/archive/patch-2209-61-0.sql for an example from the last time we extended this sort of thing.
Adding William for a second DB review. Diff comments: > diff --git a/database/schema/patch-2210-26-1.sql > b/database/schema/patch-2210-26-1.sql > new file mode 100644 > index 0000000..08124d6 > --- /dev/null > +++ b/database/schema/patch-2210-26-1.sql > @@ -0,0 +1,13 @@ > +-- Copyright 2021 Canonical Ltd. This software is licensed under the > +-- GNU Affero General Public License version 3 (see the file LICENSE). > + > +SET client_min_messages=ERROR; > + > +ALTER TABLE Snap > + ADD COLUMN project INT, > + ADD CONSTRAINT snap__project__fk > + FOREIGN KEY (project) REFERENCES Product(id); You could spell this a bit more concisely as "ADD COLUMN project integer REFERENCES product" if you wanted. > + > +COMMENT ON COLUMN Snap.project IS 'The project which is the pillar for this > Snap'; > + > +INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 26, 1); -- https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/397459 Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:snap-pillar-db. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
