Colin Watson has proposed merging ~cjwatson/launchpad:py3-fake-logger-exc-info
into launchpad:master.
Commit message:
Fix handling of exc_info parameter in FakeLogger
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/398031
Passing exc_info=False shouldn't cause FakeLogger.message to attempt to print
an exception.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:py3-fake-logger-exc-info into launchpad:master.
diff --git a/lib/lp/services/log/logger.py b/lib/lp/services/log/logger.py
index ea1f61e..07ddd84 100644
--- a/lib/lp/services/log/logger.py
+++ b/lib/lp/services/log/logger.py
@@ -132,7 +132,7 @@ class FakeLogger:
prefix = LEVEL_PREFIXES.get(level, "%d>" % level)
print(prefix, self._format_message(msg, *stuff), file=output_file)
- if 'exc_info' in kw:
+ if kw.get('exc_info', False):
traceback.print_exc(file=output_file)
def log(self, level, *stuff, **kw):
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
