Review: Approve
Diff comments: > diff --git a/lib/lp/snappy/model/snap.py b/lib/lp/snappy/model/snap.py > index dabc6fe..f173d65 100644 > --- a/lib/lp/snappy/model/snap.py > +++ b/lib/lp/snappy/model/snap.py > @@ -1141,6 +1145,9 @@ class Snap(Storm, WebhookTargetMixin): > return True > if user is None: > return False > + roles = IPersonRoles(user) > + if roles.in_admin: > + return True Is this needed, since get_snap_privacy_filter still handles the admin case even though it does so differently? > store = IStore(self) > return not store.find( > Snap, -- https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/398318 Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:snap-pillar-subscribe. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
