Review: Approve


Diff comments:

> diff --git a/lib/lp/oci/interfaces/ocirecipe.py 
> b/lib/lp/oci/interfaces/ocirecipe.py
> index 5ed23a7..ecc90c8 100644
> --- a/lib/lp/oci/interfaces/ocirecipe.py
> +++ b/lib/lp/oci/interfaces/ocirecipe.py
> @@ -241,6 +241,11 @@ class IOCIRecipeView(Interface):
>          description=_("True if this recipe is official for its OCI 
> project."),
>          readonly=True)
>  
> +    private = Bool(
> +        title=_("Is this OCI recipe private?"),
> +        required=False, readonly=True,

This is never None, so can be `required=True`.

> +        description=_("True if this recipe is private. False otherwise."))
> +
>      pillar = Attribute('The pillar of this OCI recipe.')
>  
>      @call_with(check_permissions=True, user=REQUEST_USER)


-- 
https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/399987
Your team Launchpad code reviewers is subscribed to branch 
~pappacena/launchpad:ocirecipe-subscribe-removal-job.

_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Reply via email to