Pushed the requested changes. It worth another review round. Diff comments:
> diff --git a/database/schema/patch-2210-31-0.sql > b/database/schema/patch-2210-31-0.sql > new file mode 100644 > index 0000000..9bcceb5 > --- /dev/null > +++ b/database/schema/patch-2210-31-0.sql > @@ -0,0 +1,21 @@ > +-- Copyright 2021 Canonical Ltd. This software is licensed under the > +-- GNU Affero General Public License version 3 (see the file LICENSE). > + > +SET client_min_messages=ERROR; > + > +ALTER TABLE Message > + ADD COLUMN date_deleted timestamp without time zone, > + ADD COLUMN date_last_edit timestamp without time zone; Fixing it! > + > +CREATE TABLE MessageRevision ( > + id serial PRIMARY KEY, > + message integer NOT NULL REFERENCES Message, > + content text, `Message.text_contents` fetches the chunks, and I was a bit worried that increasing query time there could affect load time of the UI. Anyway, I'm pushing the changes here and in following MPs to have a MessageRevisionChunk table and implement the above steps when editing a message. > + date_created timestamp without time zone, > + date_deleted timestamp without time zone > +); > + > +CREATE UNIQUE INDEX messagerevision__message__date_created__key > + ON MessageRevision(message, date_created); > + > +INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 31, 0); -- https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/401976 Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:comment-editing-db-patch. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
