Review: Needs Fixing
Diff comments: > diff --git a/lib/lp/code/configure.zcml b/lib/lp/code/configure.zcml > index a373286..7a019ed 100644 > --- a/lib/lp/code/configure.zcml > +++ b/lib/lp/code/configure.zcml > @@ -548,7 +548,7 @@ > <!-- CodeReviewComment --> > > <class class="lp.code.model.codereviewcomment.CodeReviewComment"> > - <require permission="launchpad.Edit" > + <require permission="launchpad.Driver" I understand the intent of this, but launchpad.Driver has a specific meaning (see lib/lp/permissions.zcml) and it's not this. Could you use launchpad.Owner instead? > > interface="lp.services.messages.interfaces.message.IMessageEdit" /> > <allow > interface="lp.code.interfaces.codereviewcomment.ICodeReviewCommentView"/> > <allow interface="lp.code.interfaces.branchtarget.IHasBranchTarget"/> -- https://code.launchpad.net/~pappacena/launchpad/+git/launchpad/+merge/403146 Your team Launchpad code reviewers is subscribed to branch ~pappacena/launchpad:prevent-admins-from-editing-codereview-comment. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
