I like the idea, but one tweak would make me significantly happier ... Diff comments:
> diff --git a/.launchpad.yaml b/.launchpad.yaml > new file mode 100644 > index 0000000..4a5d057 > --- /dev/null > +++ b/.launchpad.yaml > @@ -0,0 +1,25 @@ > +pipeline: > + - docs > + - lint > + > +jobs: > + docs: > + architectures: amd64 > + packages: > + - tox > + run: "tox -e docs" > + series: focal > + lint: > + architectures: amd64 > + packages: > + - tox > + - git > + - curl > + run: | > + curl -LO https://go.dev/dl/go1.18.4.linux-amd64.tar.gz I'm not comfortable with downloading a file from some random website for this. Can we at least use the `go` snap instead? Its `latest/stable` channel has 1.18.3, so we should just be able to use `snaps: [go]` (and maybe add `/snap/bin` to `PATH` if it's not there already). > + tar -C /usr/local/ -xzf go1.18.4.linux-amd64.tar.gz > + export GOROOT=/usr/local/go > + export GOPATH=$HOME/go > + export PATH=$GOPATH/bin:$GOROOT/bin:$PATH > + tox -e lint > + series: focal -- https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/427516 Your team Launchpad code reviewers is requested to review the proposed merge of ~jugmac00/launchpad:run-pre-commit-in-ci into launchpad:master. _______________________________________________ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : [email protected] Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
