Jürgen Gmach has proposed merging
~jugmac00/launchpad:add-livefs-to-skipset-for-consistency-warning into
launchpad:master.
Commit message:
Add `livefs` to skipset for consistency warning
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~jugmac00/launchpad/+git/launchpad/+merge/431440
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~jugmac00/launchpad:add-livefs-to-skipset-for-consistency-warning into
launchpad:master.
diff --git a/lib/lp/registry/model/person.py b/lib/lp/registry/model/person.py
index e2f7078..f0662a6 100644
--- a/lib/lp/registry/model/person.py
+++ b/lib/lp/registry/model/person.py
@@ -2717,6 +2717,7 @@ class Person(
("karmacache", "person"),
("karmatotalcache", "person"),
("logintoken", "requester"),
+ ("livefs", "owner"),
("personlanguage", "person"),
("personlocation", "person"),
("personsettings", "person"),
diff --git a/lib/lp/registry/tests/test_team.py b/lib/lp/registry/tests/test_team.py
index 7a95184..fef6609 100644
--- a/lib/lp/registry/tests/test_team.py
+++ b/lib/lp/registry/tests/test_team.py
@@ -26,11 +26,16 @@ from lp.registry.interfaces.person import IPersonSet, ITeamPublic
from lp.registry.interfaces.teammembership import TeamMembershipStatus
from lp.registry.model.persontransferjob import PersonTransferJob
from lp.services.database.interfaces import IMasterStore
+from lp.services.features.testing import FeatureFixture
from lp.services.identity.interfaces.emailaddress import IEmailAddressSet
from lp.services.identity.model.emailaddress import EmailAddress
from lp.services.mail.sendmail import format_address_for_person
from lp.services.messages.interfaces.message import IDirectEmailAuthorization
from lp.soyuz.enums import ArchiveStatus
+from lp.soyuz.interfaces.livefs import (
+ LIVEFS_FEATURE_FLAG,
+ LIVEFS_WEBHOOKS_FEATURE_FLAG,
+)
from lp.testing import (
TestCaseWithFactory,
login_celebrity,
@@ -604,6 +609,24 @@ class TestVisibilityConsistencyWarning(TestCaseWithFactory):
self.team.visibilityConsistencyWarning(PersonVisibility.PRIVATE)
)
+ def test_no_warning_for_livefs(self):
+ with FeatureFixture(
+ {LIVEFS_FEATURE_FLAG: "on", LIVEFS_WEBHOOKS_FEATURE_FLAG: "on"}
+ ):
+ member = self.factory.makePerson()
+ self.team.addMember(
+ member, member, status=TeamMembershipStatus.APPROVED
+ )
+ self.factory.makeLiveFS(
+ registrant=member,
+ owner=self.team,
+ )
+ self.assertIsNone(
+ self.team.visibilityConsistencyWarning(
+ PersonVisibility.PRIVATE
+ )
+ )
+
class TestPersonJoinTeam(TestCaseWithFactory):
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
