Diff comments:
> diff --git a/lib/lp/services/features/browser/edit.py
> b/lib/lp/services/features/browser/edit.py
> index 3acc671..36ea7a3 100644
> --- a/lib/lp/services/features/browser/edit.py
> +++ b/lib/lp/services/features/browser/edit.py
> @@ -69,7 +69,7 @@ class FeatureControlView(LaunchpadFormView):
>
> def canSubmit(self, action):
> """Is the user authorized to change the rules?"""
> - return check_permission("launchpad.Admin", self.context)
> + return check_permission("launchpad.EditFeatureRules", self.context)
What is the difference between having the `launchpad.Admin` permission on the
feature rules vs `launchpad.EditFeatureRules`? Is there a reason why we cannot
grant `launchpad.Admin` permissions on just this object to an additional
celebrity here?
>
> @action("Change", name="change", condition=canSubmit)
> def change_action(self, action, data):
--
https://code.launchpad.net/~andrey-fedoseev/launchpad/+git/launchpad/+merge/432249
Your team Launchpad code reviewers is requested to review the proposed merge of
~andrey-fedoseev/launchpad:edit-feature-rules into launchpad:master.
_______________________________________________
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : [email protected]
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
